test(streams): add unit tests for StreamsService and StreamsController#302
Open
coderolisa wants to merge 1 commit into
Open
test(streams): add unit tests for StreamsService and StreamsController#302coderolisa wants to merge 1 commit into
coderolisa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #201
Summary
Added tests: Created api/src/streams/streams.service.spec.ts and api/src/streams/streams.controller.spec.ts.
Service coverage: Tests for StreamsService — create, list (pagination & filtering), findById (NotFound), update (status transitions: inactive→active success, active→active conflict, error→active conflict), and delete (existing removed, non-existent NotFound).
Controller coverage: Tests for StreamsController — verifies each endpoint delegates to StreamsService with correct params (create, list, findById, update, delete). Guards are mocked to avoid side-effects.
Implementation detail: Mocked AuthGuard and StreamOwnershipGuard in the controller spec to prevent environment validation from running during imports.
Validation handling: Tests assert exceptions thrown by service (NotFoundException, ConflictException) for invalid operations.
Verification: Installed dev dependencies and ran the API test suite; all tests pass locally (66 passed).