test: add unit tests for TagsService, TagsController, and slugify (#202)#299
Open
iyanumajekodunmi756 wants to merge 1 commit into
Open
Conversation
…treamRollz#202) - api/src/tags/slugify.spec.ts: 12 cases covering NFD normalisation, diacritics, special chars, unicode, length cap, and non-string input - api/src/tags/tags.service.spec.ts: 11 cases covering list pagination (hasMore true/false), attachToStream (new tag, reuse existing slug, whitespace trimming, empty/non-alphanumeric name), and detachFromStream (success, tag not found, tag not attached to stream) - api/src/tags/tags.controller.spec.ts: 8 cases covering TagsListController defaults and delegation, StreamTagsController guard reflection, attach delegation, and detach delegation All 83 tests pass (31 new + 52 existing) across 9 suites. Closes XStreamRollz#202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 83 tests pass (31 new + 52 existing) across 9 suites.
Closes #202
Summary
Provide a short description of the changes in this PR and the motivation/why.
closes #202
Related issues
Link any related issues. Use
Closes #<id>to close issues automatically.Closes:
Type of change
Match the PR title to Conventional Commits:
<type>(<scope>): <summary>.Testing performed
Describe how you tested this change. Include commands, environment, and any setup steps.
Example:
Screenshots (if applicable)
Attach screenshots or animated GIFs for UI changes.
Checklist — author
origin/mainand resolved conflicts.npm run lint,npm run build,npm test.Checklist — reviewer guidance
Follow the full PR process in CONTRIBUTING.md — particularly: sync with
main, run quality gates, request a CODEOWNER review, and use squash-and-merge with a Conventional Commit-style squash message.