infra: implement shared connection pool management (#139)#298
Open
sheyman546 wants to merge 1 commit into
Open
infra: implement shared connection pool management (#139)#298sheyman546 wants to merge 1 commit into
sheyman546 wants to merge 1 commit into
Conversation
- Add api/src/database/database.module.ts as a @global NestJS module that provides a single pg.Pool instance under the PG_POOL token - Remove individual new Pool() calls from StreamsDbRepository, TagsDbRepository, UsersRepository, AuditService, PasswordResetService, and DatabaseHealthIndicator - Inject PG_POOL via @Inject(PG_POOL) in all six consumers - Import DatabaseModule in AppModule; @global() propagates the token to all feature modules automatically - Add database.module.spec.ts verifying singleton Pool provision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #139. Replaces six independent
new Pool()instances with a single sharedpg.Poolprovided via NestJS DI.Changes
api/src/database/database.module.ts— new@Global()module exporting a singletonPoolunder thePG_POOLinjection tokenapi/src/app.module.ts— importsDatabaseModule(one import propagates the token globally)@Inject(PG_POOL)instead ofnew Pool():StreamsDbRepositoryTagsDbRepositoryUsersRepositoryAuditServicePasswordResetServiceDatabaseHealthIndicator(removed now-redundantOnModuleDestroy)api/src/database/database.module.spec.ts— verifies singletonPoolprovisionTested
tsc --noEmitcleancloses infra: Implement shared connection pool management (api/src/database/ + 3 services) #139