fix(api): restrict WebSocket CORS to trusted origins#296
Merged
Conversation
Contributor
|
Hey @leandromasotti — great work on this! Replacing the wildcard CORS with env-driven, comma-separated trusted origins (plus the sensible localhost fallback for dev) is exactly the move. The unit tests covering the resolver look thorough. Merged, thanks for tightening the gateway! \ud83d\ude80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restrict WebSocket CORS from wildcard to trusted origins
Related issues
Link any related issues. Use
Closes #189to close issues automatically.Closes:
Type of change
Match the PR title to Conventional Commits:
<type>(<scope>): <summary>.Testing performed
6 unit tests were added
Example:
Screenshots (if applicable)
Attach screenshots or animated GIFs for UI changes.
Checklist — author
origin/mainand resolved conflicts.npm run lint,npm run build,npm test.Checklist — reviewer guidance
Follow the full PR process in CONTRIBUTING.md — particularly: sync with
main, run quality gates, request a CODEOWNER review, and use squash-and-merge with a Conventional Commit-style squash message.