Skip to content

fix(api): enforce JWT secret and remove hardcoded fallbacks#295

Merged
Xhristin3 merged 1 commit into
XStreamRollz:mainfrom
Spycall:fix/jwt-enforce-secret
Jun 18, 2026
Merged

fix(api): enforce JWT secret and remove hardcoded fallbacks#295
Xhristin3 merged 1 commit into
XStreamRollz:mainfrom
Spycall:fix/jwt-enforce-secret

Conversation

@Spycall

@Spycall Spycall commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Enforce a required JWT_SECRET, remove hardcoded dev fallbacks, and add a shared JWT config that generates a clearly warned, random secret only in development.

Closes #137

Copy link
Copy Markdown
Contributor

Hey @Spycall \u2014 solid security fix. Centralizing JWT config, dropping the hardcoded fallbacks, and auto-generating a dev secret with a warning lines up precisely with what #137 called for. Closes #137 cleanly. Merged, thanks for locking this down! \ud83d\udd10

@Xhristin3 Xhristin3 merged commit c23c166 into XStreamRollz:main Jun 18, 2026
2 checks passed
@Xhristin3 Xhristin3 mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: Remove hardcoded fallback JWT secrets (api/src/auth/auth.module.ts)

2 participants