Added log ip-masking#276
Conversation
|
Hi @nanaabdul1172 👋 — appreciate the IP-masking work for #222, the new |
Xhristin3
left a comment
There was a problem hiding this comment.
Nice feature — LOG_IP_MASKING with modes none, last-octet, full-hash covering v4/v6/v4-mapped is solid. Holding on merge because quality CI is red:\n\napi test suite has one failure:\n- RequestLoggerMiddleware › logs a 2xx request with the required fields on completion\n- the assertion expects "1.2.3.4" but now receives "1.2.3.0" — i.e. your last-octet masking is actually working, the existing test just predates it.\n\nPlease update that assertion in api/src/middleware/request-logger.middleware.spec.ts to expect the masked IP ("1.2.3.0") so it reflects the new behavior. Re-request review once CI is green 🙏
Xhristin3
left a comment
There was a problem hiding this comment.
Thanks for working on the IP masking feature — important for GDPR compliance. The CI quality check is failing right now though. Could you investigate the failing logs and push a fix so we can get it merged?
|
Hey @nanaabdul1172 \u2014 the IP-masking utility looks great. The |
|
Hello maintainer, Thank you for your patience.
Can you let me know the exact failures from your end I've fixed everyone
from my end and I can't seem to find anymore. Can it be referenced? Thank
you
…On Thu, Jun 18, 2026, 10:11 PM Xhr!st!n3 ***@***.***> wrote:
*Xhristin3* left a comment (XStreamRollz/XStreamRoll#276)
<#276 (comment)>
Hey @nanaabdul1172 <https://github.com/nanaabdul1172> \u2014 the
IP-masking utility looks great. The none / last-octet (default) /
full-hash modes and the integration into AuditInterceptor +
RequestLoggerMiddleware hit #222
<#222> exactly. CI is
red on one assertion: api/src/middleware/request-logger.middleware.spec.ts
still expects the unmasked "1.2.3.4" while the middleware now correctly
produces "1.2.3.0". Could you update that expectation to match the masked
output? Tiny fix and this lands. \ud83d\ude4c
—
Reply to this email directly, view it on GitHub
<#276?email_source=notifications&email_token=BBCOMAWZ2CV4QE7RRG3BIJD5ARLG5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUGYYTMMZSGU42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4746163259>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBCOMAX6OWQEKY5UZLMJAGT5ARLG5AVCNFSNUABGKJSXA33TNF2G64TZHMYTCMZUHA2TEMBVHE5US43TOVSTWNBWG42TENJVGMYDHILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BBCOMAXTJ5SQ625DIEQLMQD5ARLG5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUGYYTMMZSGU42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BBCOMAXUXCGC4UZ4V6R5GOL5ARLG5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUGYYTMMZSGU42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closes #222
Added LOG_IP_MASKING env var (default: "last-octet"). Masked the last octet of IPv4 addresses and the last 64 bits of IPv6 addresses before logging or storing.