[WIP] v2.2.0 Clicking in plot window does not change frame.#2
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis of Plot Window Click Issue
Investigated the v2.2.0 issue where clicking in the plot window does not change the frame. The issue is in the
PlotWindow.cppevent handling logic.Current Analysis
The problem is in the
PlotWindow::eventFiltermethod around lines 1048-1062. When handling regular left mouse clicks (not Ctrl+click), the code:State::getInstance()->changeActiveFrameTrial(frame)startFrameandendFramevariablesnoSelectionflagThis causes the visual frame marker in the plot to not update properly even though the underlying frame state changes.
Implementation Plan
Root Cause
The Ctrl+click handler (lines 1038-1040) properly sets:
startFrame = frame; endFrame = frame; noSelection = true;But the regular click handler (lines 1048-1062) is missing these assignments, causing visual inconsistencies.
Fixes #1.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.