Update to release 2.8.0 - #900
Closed
github-actions[bot] wants to merge 23 commits into
Closed
github-actions[bot] wants to merge 23 commits into
github-actions[bot] wants to merge 23 commits into
Conversation
Signed-off-by: Zhu Chenrui <boomzero_zcr@outlook.com>
(cherry picked from commit c7137ff)
Signed-off-by: Zhu Chenrui <boomzero_zcr@outlook.com> (cherry picked from commit 07d7590) Update feature.yml Signed-off-by: Zhu Chenrui <boomzero_zcr@outlook.com> (cherry picked from commit 1a99430) Update docs.yml Signed-off-by: Zhu Chenrui <boomzero_zcr@outlook.com> (cherry picked from commit 6017bcf)
Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="Update.json">
<violation number="1" location="Update.json:2940">
P2: The version key "1.999990.0" is likely a typo for "1.10.0" and will be treated as newer than all 2.x releases, which can break update ordering/selection. Keep the intended 1.10.0 key to avoid mis-sorting releases.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "Notes": "No release notes were provided for this release." | ||
| }, | ||
| "1.10.0": { | ||
| "1.999990.0": { |
Contributor
There was a problem hiding this comment.
P2: The version key "1.999990.0" is likely a typo for "1.10.0" and will be treated as newer than all 2.x releases, which can break update ordering/selection. Keep the intended 1.10.0 key to avoid mis-sorting releases.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Update.json, line 2940:
<comment>The version key "1.999990.0" is likely a typo for "1.10.0" and will be treated as newer than all 2.x releases, which can break update ordering/selection. Keep the intended 1.10.0 key to avoid mis-sorting releases.</comment>
<file context>
@@ -2937,7 +2937,7 @@
"Notes": "No release notes were provided for this release."
},
- "1.10.0": {
+ "1.999990.0": {
"UpdateDate": 1753443146018,
"Prerelease": false,
</file context>
Suggested change
| "1.999990.0": { | |
| "1.10.0": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to release 2.8.0
Summary by cubic
Prepare release 2.8.1 by updating version strings in package.json and XMOJ.user.js. Update Update.json by renaming key 1.10.0→1.999990.0, adding 2.8.0, and adding 2.8.1 marked as prerelease.
Written for commit 28fa87c. Summary will update on new commits.