Skip to content

Release as 4.0.0: the rating redesign is a breaking change - #1057

Merged
boomzero merged 6 commits into
devfrom
bump-4.0.0
Oct 6, 2026
Merged

boomzero merged 6 commits into
devfrom
bump-4.0.0

Conversation

@boomzero

@boomzero boomzero commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Release the pending stable version as 4.0.0 instead of 3.9.0. The rating redesign (#1048) is a breaking change: ratings are computed differently, so every user's rating changes and isn't comparable with the old one, and the yellow tier is now orange.

How does this PR accomplish the above?:

  • Update.json: the stable 3.9.0 entry is renamed to 4.0.0. It is still the last key, still Prerelease: false, and keeps its 8 aggregated PRs. Its notes now open with a 重大变更 paragraph about the rating change.
  • XMOJ.user.js @version and package.json version → 4.0.0.
  • The notes string contains //!ci-no-touch, so UpdateVersion removes the marker and exits instead of bumping to 4.0.1. The JSON stays valid in the meantime, so tests and the site keep working.
  • After merge, Prerelease publishes 4.0.0 from dev (the guard skips only stable releases), and the release PR Stable release 4.0.0: merge dev into master #1056 then publishes 4.0.0 as stable. UpdateToRelease on Stable release 4.0.0: merge dev into master #1056 will see the last entry is already stable and change nothing.
  • Don't edit this PR's title or body. An edited event would run UpdateVersion again and add a 4.0.1 entry.

npm test: 99/99 pass locally.

The leftover 3.9.0 prerelease on GitHub (tag 3.9.0) is untouched. A maintainer can delete it after 4.0.0 ships.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code.
  3. I have tested my changes.
  4. I am willing to help maintain this change if there are issues with it later.
  5. It is compatible with the GNU General Public License v3.0
  6. I have squashed any insignificant commits. (git rebase)
  7. I have checked that another pull request for this purpose does not exist.
  8. I have considered and confirmed that this submission will be valuable to others.
  9. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  10. I give this submission freely and claim no ownership to its content.
  11. I have verified that my changes work correctly in both the new UI and the old/classic UI.

  • I have read the above and my PR is ready for review. Check this box to confirm

🤖 Generated with Claude Code

https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp

Summary by Sourcery

Release the rating redesign as stable version 4.0.0 with synchronized version metadata and breaking-change notes.

Enhancements:

  • Align the project and userscript versions with the 4.0.0 stable release and document the rating redesign as a breaking change.

Documentation:

  • Update release metadata and notes to announce the redesigned, non-comparable rating system and the renamed yellow tier.

Summary by cubic

Releases the rating redesign as stable 4.0.0 in Update.json, with userscript and package versions set to match.

  • The stable 3.9.0 entry is renamed to 4.0.0 in Update.json, and the release notes lead with the breaking rating change.
  • The //!ci-no-touch marker that blocked the automation from bumping the version has been stripped again by the automation, so the next event may re-bump to 4.0.1; the earlier accidental 4.0.1 bump was already reverted.
  • The rating redesign is breaking: ratings now come from problem-solving ability rather than AC rate, so they aren't comparable with old scores, and the yellow tier is now orange.
  • The leftover 3.9.0 prerelease tag on GitHub is left untouched.

Written for commit f974848. Summary will update on new commits.

Review in cubic

Rename the stable 3.9.0 entry to 4.0.0 in Update.json, XMOJ.user.js and
package.json, and lead the release notes with the rating change. The
//!ci-no-touch marker keeps UpdateVersion from bumping this to 4.0.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp
@sourcery-ai

sourcery-ai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Sorry @boomzero, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 10 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@hendragon-bot hendragon-bot Bot added the user-script This issue or pull request is related to the main user script label Oct 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T05:11:24.521573Z c61b03b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sourcery-ai

sourcery-ai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Promotes the pending release to 4.0.0 to signal the rating redesign's breaking compatibility change, updates release notes and automation safeguards, and synchronizes the userscript and package metadata versions.

Flow diagram for the 4.0.0 release promotion

flowchart TD
    A[Pending 3.9.0 stable entry] --> B[Rename release entry to 4.0.0]
    B --> C[UpdateVersion processes release notes]
    C --> D{//!ci-no-touch present?}
    D -->|Yes| E[Remove marker and stop version bump]
    E --> F[Keep Update.json valid at 4.0.0]
    F --> G[Prerelease publishes 4.0.0 from dev]
    G --> H[UpdateToRelease sees stable final entry]
    H --> I[Publish 4.0.0 as stable without changes]
Loading

File-Level Changes

Change Details Files
Reclassify the pending stable release as a breaking 4.0.0 release and document the rating migration impact.
  • Rename the stable Update.json entry from 3.9.0 to 4.0.0 while preserving its prerelease status, aggregated PRs, and release ordering.
  • Add release notes explaining that the redesigned rating is not comparable with previous ratings and that the yellow tier is now orange.
  • Add the CI no-touch marker to prevent automated version bumping from creating a 4.0.1 entry during the release workflow.
Update.json
Synchronize project and userscript metadata with the new major release version.
  • Update the userscript metadata version to 4.0.0.
  • Update the npm package version to 4.0.0.
XMOJ.user.js
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying xmoj-script-dev-channel with  Cloudflare Pages  Cloudflare Pages

Latest commit: f974848
Status:⚡️  Build in progress...

View logs

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Oct 6, 2026
Restores 4.0.0 and re-adds //!ci-no-touch so UpdateVersion strips it
instead of bumping again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@pull-request-size pull-request-size Bot added size/XS and removed size/S labels Oct 6, 2026
@boomzero
boomzero merged commit 136e268 into dev Oct 6, 2026
3 of 5 checks passed
@boomzero
boomzero deleted the bump-4.0.0 branch October 6, 2026 05:12
boomzero added a commit to boomzero/XMOJ-Script that referenced this pull request Oct 6, 2026
UpdateVersion also runs on edited events, and AI reviewers (cubic,
Sourcery) edit PR descriptions on the author's behalf, so the [bot]
actor guard does not catch them. On XMOJ-Script-dev#1057 such an edit bumped the
manual 4.0.0 to 4.0.1 minutes after the PR was opened; the same path
explains the prerelease-only 3.0.0. An edit now only refreshes this
PR's own latest entry and otherwise exits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E5dr7XTsCeoamqLSiT9rLp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant