Repository navigation
sync: dev to extern-contrib #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c1b6d4b
fix: reuse navbar styler and clean up resize listeners
boomzero d175414
3.8.1
github-actions[bot] 0e3cbb5
Update version info to 3.8.1
github-actions[bot] 519b281
fix: restore navbar styling and remove owned artifacts on teardown
boomzero 965f08a
Update time and description of 3.8.1
github-actions[bot] 51dc11e
Update time and description of 3.8.1
github-actions[bot] 56c4989
Update time and description of 3.8.1
github-actions[bot] f21d58c
Update time and description of 3.8.1
github-actions[bot] ac477fe
fix: keep downloads out of the navbar spacer
boomzero 4654237
Update time and description of 3.8.1
github-actions[bot] 3fcc576
Update time and description of 3.8.1
github-actions[bot] a64b24a
fix: load the same monochrome fonts on web and classic pages
boomzero 8381325
Update time and description of 3.8.1
github-actions[bot] 8758133
Update time and description of 3.8.1
github-actions[bot] b46e5c2
Merge pull request #1036 from XMOJ-Script-dev/codex/fix-navbar-listen…
boomzero 1aeb907
fix: use consistent Chinese navbar fallback fonts
boomzero 66d0fbb
3.8.2
github-actions[bot] ac3405d
Update version info to 3.8.2
github-actions[bot] a7efe58
fix: anchor navbar before Bootstrap CSS loads
boomzero c730563
Update time and description of 3.8.2
github-actions[bot] 11dd0db
Merge pull request #1039 from XMOJ-Script-dev/codex/fix-navbar-cjk-font
boomzero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): When a page-owned
blur-overlayornavbar-spaceris replaced before the nextUpdateNavbarStyler()call, the new element overwritesrestoreOverlayStylesorrestoreSpacerStyleswhile the old modified element is no longer tracked. Teardown restores only the replacement, leaving the original page-owned element with XMOJ's dimensions.Triggers: When Vue or another page handler replaces an existing page-owned overlay or spacer between navbar refreshes.
Suggested fix: Restore the previously borrowed element before replacing its restore callback, or track each borrowed element and its restoration callback independently.