Skip to content

Harden tests and modernize package metadata - #2

Merged
mxkh72 merged 6 commits into
masterfrom
codex/review-fixes
Feb 22, 2026
Merged

Harden tests and modernize package metadata#2
mxkh72 merged 6 commits into
masterfrom
codex/review-fixes

Conversation

@mxkh72

@mxkh72 mxkh72 commented Feb 22, 2026

Copy link
Copy Markdown
Member

Summary

  • harden failure-path tests so expected throws are enforced
  • remove force-cast from tests and replace with safe assertions
  • modernize package/docs metadata by moving to swift-tools-version:5.10 and removing the stale Carthage support claim
  • preserve the existing Requirement.isValid design (non-throwing, returns false when validation throws)
  • add targeted tests for previously untested paths in Requirement and Check.nonEmpty
  • increase core package coverage to 100% for Requirement.swift and Check.swift (line/function/region, via llvm-cov)

Validation

  • swift test
  • swift test --enable-code-coverage
  • xcrun llvm-cov report .build/arm64-apple-macosx/debug/XCERequirementPackageTests.xctest/Contents/MacOS/XCERequirementPackageTests -instr-profile .build/arm64-apple-macosx/debug/codecov/default.profdata Sources/Core/Requirement.swift Sources/Core/Check.swift Sources/Core/Aliases.swift

Commits

  • test: enforce expected throws in failure-path cases
  • test: replace force-cast with safe input assertion
  • docs: align Swift version metadata and install guidance
  • Revert "api: make isValid rethrow evaluation errors"
  • test: add coverage for requirement and nonEmpty edge paths

@mxkh72 mxkh72 changed the title Harden tests and clarify requirement validation semantics Harden tests and modernize package metadata Feb 22, 2026
@mxkh72
mxkh72 merged commit aa1dfd6 into master Feb 22, 2026
4 checks passed
@mxkh72
mxkh72 deleted the codex/review-fixes branch February 22, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant