fix: adjust findsymbols definition to work in BSD make(1)#453
Merged
Conversation
stefan-b-jakobsson
approved these changes
Jan 19, 2026
Collaborator
|
This fix works, and is needed for the project to build on MacOS after some recent changes to the Makefile. |
mooinglemur
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro added in 8efde2d to wrap
findsymbolsand abort on failure incuded GNU make(1)-specific features ($(subst)), breaking the build on platforms using BSD make (like macOS). This removes the$(subst)call in thefindsymbolsmacro definition in favor of having thefindsymbolsscript itself output a backslash in front of the dollar signs in its hex literals.Fixes #448.