fix: Update flashing of menu item on first render#3930
Open
mannycarrera4 wants to merge 1 commit into
Open
Conversation
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-flash
|
| Run status |
|
| Run duration | 02m 31s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
86
|
|
|
0
|
|
|
863
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.58%
|
|
|---|---|
|
|
1538
|
|
|
372
|
Accessibility
99.32%
|
|
|---|---|
|
|
6 critical
5 serious
0 moderate
2 minor
|
|
|
78
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an initial-render focus styling bug in the @workday/canvas-kit-react/collection cursor utilities that could cause a menu/list item to appear “focused” (blue flash) when cursorId is an empty string.
Changes:
- Update
isCursorto explicitly treatnull,undefined, and''cursor IDs as “no cursor” (always returnsfalse). - Add unit tests covering
isCursorbehavior for empty-string, null/undefined, string, and array cursor IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/react/collection/lib/useCursorListModel.tsx | Fixes isCursor logic to avoid false positives when cursorId is empty. |
| modules/react/collection/spec/useCursorModel.spec.tsx | Adds test coverage for isCursor, including the empty-string regression case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
josh-bagwell
approved these changes
May 19, 2026
sheelah
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3712
Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)