Skip to content

fix: Update flashing of menu item on first render#3930

Open
mannycarrera4 wants to merge 1 commit into
Workday:supportfrom
mannycarrera4:mc-flash
Open

fix: Update flashing of menu item on first render#3930
mannycarrera4 wants to merge 1 commit into
Workday:supportfrom
mannycarrera4:mc-flash

Conversation

@mannycarrera4
Copy link
Copy Markdown
Contributor

Summary

Fixes: #3712

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@cypress
Copy link
Copy Markdown

cypress Bot commented May 5, 2026

Workday/canvas-kit    Run #10871

Run Properties:  status check passed Passed #10871  •  git commit 6535b3bf9b ℹ️: Merge b8db8ad0ee643a3bda489f9ac0adbad4f031b91c into 45a9962cf11155d55db53cb5f291...
Project Workday/canvas-kit
Branch Review mc-flash
Run status status check passed Passed #10871
Run duration 02m 31s
Commit git commit 6535b3bf9b ℹ️: Merge b8db8ad0ee643a3bda489f9ac0adbad4f031b91c into 45a9962cf11155d55db53cb5f291...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 86
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 863
View all changes introduced in this branch ↗︎
UI Coverage  19.58%
  Untested elements 1538  
  Tested elements 372  
Accessibility  99.32%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 78  

@mannycarrera4 mannycarrera4 marked this pull request as ready for review May 5, 2026 20:55
@RayRedGoose RayRedGoose requested a review from Copilot May 6, 2026 15:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an initial-render focus styling bug in the @workday/canvas-kit-react/collection cursor utilities that could cause a menu/list item to appear “focused” (blue flash) when cursorId is an empty string.

Changes:

  • Update isCursor to explicitly treat null, undefined, and '' cursor IDs as “no cursor” (always returns false).
  • Add unit tests covering isCursor behavior for empty-string, null/undefined, string, and array cursor IDs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/react/collection/lib/useCursorListModel.tsx Fixes isCursor logic to avoid false positives when cursorId is empty.
modules/react/collection/spec/useCursorModel.spec.tsx Adds test coverage for isCursor, including the empty-string regression case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label May 7, 2026
@RayRedGoose RayRedGoose requested a review from Copilot May 19, 2026 12:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@sheelah sheelah self-requested a review May 19, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants