Skip to content

Fix: months outside ad-hoc cycle #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khairahscorner merged 1 commit into from
Mar 1, 2026
Merged

Fix: months outside ad-hoc cycle #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions assets/js/registration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const registrationController = (function(jQuery) {
const CLASS_HIDDEN = 'd-none';
const MENTORSHIP_OPEN_MONTH = 3; //March
const MENTORSHIP_CLOSE_MONTH = 11; //November
const MENTORSHIP_ADHOC_OPEN_MONTH = 5; //May
const MENTORSHIP_ADHOC_CLOSE_MONTH = 11; //November

const checkAdHocSessions = function() {
jQuery('.card-mentor').each(function() {
Expand All @@ -17,12 +17,12 @@ const registrationController = (function(jQuery) {
const currentDay = currentDate.getDate();
const currentMonth = currentDate.getMonth() + 1;

const isMentorshipCycle = (
currentMonth >= MENTORSHIP_OPEN_MONTH &&
currentMonth <= MENTORSHIP_CLOSE_MONTH
const isAdhocMentorshipCycle = (
currentMonth >= MENTORSHIP_ADHOC_OPEN_MONTH &&
currentMonth <= MENTORSHIP_ADHOC_CLOSE_MONTH
);

if (currentDay <= daysOpen && isMentorshipCycle) {
if (currentDay <= daysOpen && isAdhocMentorshipCycle) {
if (mentorType !== 'long-term') {
if (mentorAvailability.includes(currentMonth.toString())) {
jQuery(`#registration-link-${mentorIndex}`).removeClass(CLASS_HIDDEN);
Expand Down