Repository navigation
Overhaul the poll system - #6751
Merged
Merged
Conversation
…tions and options
…ace voting and result toggle
…es, result order and leading-option class
… drop the separate widget endpoint
…ace refresh of all embeds
…bedded poll widgets
…ead of a "not available" notice
…C vote endpoint to standalone polls
…s with ACL snapshot
…party poll containers
TimWolla
reviewed
Oct 25, 2026
| $addedOptionIDs = \array_values(\array_diff($this->optionIDs, $previousOptionIDs)); | ||
| $removedOptionIDs = \array_values(\array_diff($previousOptionIDs, $this->optionIDs)); | ||
|
|
||
| WCF::getDB()->beginTransaction(); |
Member
There was a problem hiding this comment.
I believe this transaction doesn't guarantee proper idempotency, because the SELECT is not part of the transaction.
In case of a duplicated request, the INSERT IGNORE will ignore the duplicate, but the UPDATE to update the vote counts will run twice.
I think either the SELECT needs to go into the transaction with FOR UPDATE, or getAffectedRows() needs to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6481
Closes #5925