Repository navigation
Merged
Conversation
The stage and unstage controls were text characters, and the Git status code of every file was drawn in the default text colour, so a list of changes read as an undifferentiated wall of paths. Icons come from Lucide, which is free for commercial use under the ISC License. The geometry is embedded in the plugin and rasterized at runtime through the Engine's LunaSVG backend, so the package stays a single deterministic archive and one vector asset can be drawn in any colour. The status code is now drawn in the colour of its change, and the leading icon repeats that meaning as a shape. The code keeps its Git spelling, so a dual state such as AM stays readable. The icon buttons and the status code carry tooltips. An icon button is skipped while its texture is still uploading, which also keeps its tooltip attached to the right widget instead of drifting onto the previous one. THIRD_PARTY_NOTICES.md records the licence of the artwork.
ISC and MIT both ask for their notice to travel with every copy of the artwork, so the notices cannot live in the repository root alone: the repository is not what the Editor installs. The licence file and the notices now sit in the plugin package, next to the plugin code, and the Engine renders them as the plugin's License page, so no extra UI is needed to reach them. The usage page also points at the online copy, written out as plain URLs because the Editor draws plugin pages as plain text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Git panel up to 0.1.5: the file list now uses real vector icons and colour-coded status codes, and the plugin ships its own licence plus the third-party notices for that artwork inside the archive.
main(9667a29)dev(0e824a3)What's new
Vector icons across the panel
+,-,⟳characters.icons.pyrather than shipped as files, so the plugin never depends on where its package is unpacked and the build stays byte-for-byte deterministic.IconCache).Coloured file status
AMstays readable next to its icon.Licence and third-party notices inside the archive
package/plugin_pages/LICENSE— the plugin's MIT licence, byte-identical to the repository root copy.package/plugin_pages/license.md/license.zh-CN.md— the plugin's License page, carrying the MIT licence plus the Lucide (ISC) and Feather (MIT) notices.How it works
The icons are vector artwork that the Editor rasterizes at runtime. This rides on the Engine's LunaSVG-backed texture loader — a real capability, but not part of the documented plugin API. ImGui itself only draws raster textures, so there was no way to ship vector artwork inside a plugin before this.
If a future Engine release drops that capability, the panel falls back to text-only controls and everything else keeps working. This dependency is recorded under Dependencies in the changelog.
Because
ctx.image/ctx.image_buttonhave no tint parameter, the colour is baked into each icon's SVGstroke.Licensing
plusandminusderive from Feather, MIT. Both are free for commercial use.Verification
python .infernux-dev/validate.pypython -m unittest discover -s testspackage.py buildtwicesha256equal), 66 560 bytespackage.py verifypackage.py release-manifest --tag v0.1.5--tag v0.1.4correctly rejectedNew tests:
tests/test_icon_assets.py— SVG well-formedness, Lucide stroke conventions, status-table consistency, colour conversion.tests/test_package_licenses.py— parses the InxPack table of contents and asserts the licence and both notices are in the archive, that the licence file matches the repository copy byte-for-byte, that no superseded notice copy remains, and that the usage pages point at the licence page.tests/test_translation_contracts.pyextended for the 25 keys.Please test in the Editor
AMstill shows both letters, plus the icon.Known caveats
main, so they only resolve once this PR is merged.Commits
7a83686—feat: draw the panel with vector icons and coloured file status0e824a3—feat: ship the plugin licence and icon notices inside the archiveAfter merge
devintomain.v0.1.5on the merge commit.wokrlie.git_integration.inxpkgandinfernux-plugin-release.json.sha256against the published asset — it must be byte-identical.