Repository navigation
Auth: show/hide password toggle, any-character passwords - #25
Merged
Merged
Conversation
Every password input goes through Field, so the eye toggle lands on all of them at once. Also adds a test proving passwords take any character (only the length is checked), which settles the "unsupported characters" roadmap item without further code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers two roadmap items, without a spec (both are small).
Show/hide password toggle
Field.svelteadds an eye button to anytype="password"field, so it shows up on sign-in, sign-up, the password confirm screen, invite, reset, security settings and the re-enter-password prompt.aria-pressed,aria-controls) labelled "Show password" / "Wachtwoord tonen".Unsupported password characters
No code needed:
Passwords.csonly checks the length (12–128), so every character is accepted. The newSignInTests.AnyCharacterInAPasswordsets a password with accents, emoji, Greek and Chinese characters and quotes, then signs in with it.Testing
Not covered: passwords aren't Unicode-normalised, so a rare device-specific form of an accented letter could fail to match.
Closes #27
Closes #28
🤖 Generated with Claude Code