Repository navigation
Event change history (spec 010) - #24
Merged
Merged
Conversation
Spec (with clarifications and design-review decisions), plan, research R1–R12, data model, API and page contracts, and quickstart for issue #23: found time in the feed, a history card over the feed and a full history page per lesson, with the filter toggle, the 20-entry card cap and the calendar-style current details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Add tasks.md for event change history. - Drop the dark theme from FR-019: the app has a light theme only. - Add opensCard() with a vitest case per condition, so the card/navigate click rule has an automated check (constitution workflow rule). - Move hidden-row filtering into US2 (T014a, T019); the card cap counts after the filter (FR-009a). - FR-011: history-start note when the oldest kept entry is not "new", judged over all kept entries; tested once in historyView. - FR-016: identical "not found" applies to signed-in students; signed-out visitors are sent to sign-in for every id. - SC-003: quickstart and T034 record API and page load time for a 100-row lesson; T005 checks all 100 rows come back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each feed change opens the full history of its lesson: a card over the
feed on a plain click, or the /changes/{id} page on reload or a new tab.
- GET /api/me/changes/{id}/history with current or last known details,
history start and retention; same 404 for missing and not followed
- migration 006: history index and calendar.baseline_at, set on add and
on a re-baseline
- feed shows when each change was found and links to its history
- "Show all" toggle, 20-entry cap on the card, en and nl texts
T034 (manual walkthrough) stays open: a few steps were not run by hand.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Holidays list every room and class, which made the current details block very long. The summary now keeps the first 3 items and "and N more"; the full lists move to More details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Steps 3, 7, 8, 15, 16 and 20 run on real check data; step 20 on dev data with one lesson grown to 101 rows, not whole-school size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every change in the feed now opens the full history of its lesson.
<dialog>; Esc, close, backdrop and Back each step back once and return focus). Reload, Ctrl/middle-click or "Open as page" gives the full page at/changes/{id}.?all=0|1survives reload), a 20-entry cap on the card, history-start and retention notes. English and Dutch.GET /api/me/changes/{id}/history. A missing change and a change on a timetable you don't follow give the same 404.(calendar_id, event_key, id)andcalendar.baseline_at, set when a link creates the calendar and on a features re-baseline.Why
Students could see that a lesson changed, but not what happened to it before. Spec, plan and research are in
specs/010-event-change-history/.Testing
HistoryTests;OwnershipTestshas the new route).svelte-check0 errors, production build OK.quickstart.mdsteps 1–20) passed; notes at the end ofquickstart.md.For the reviewer
🤖 Generated with Claude Code