Repository navigation
test(checker): Google-shaped feed records time moves and fans them out - #21
Merged
Merged
Conversation
A report of missed time changes on a Google calendar turned out to be Google serving a stale feed, but no fixture had Google's shape: all-day VALUE=DATE events, UTC times and a "this event only" RECURRENCE-ID override. The new test moves one of each and asserts a changed/time row per event and a pending delivery per change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A missed time change on a Google calendar in production (v0.1.1) wasn't a bug. A read-only check on the server showed the calendar is
okand checked every 10 minutes, but the feed Google serves still has the old times (the newestLAST-MODIFIEDis 30 Sept). Google's iCal feed is slow to update. Still, no test fixture had Google's shape, so this adds one.What
Fixtures/google.ics/google-edited.ics: a synthetic feed in Google's format (X-WR-TIMEZONE:Europe/Brussels, an all-dayVALUE=DATEevent, UTCZtimes, a weekly series).CheckerTests.GoogleFeedTimeMovesAreRecordedAndFannedOut: moves the single event, the all-day event and one occurrence of the series (aRECURRENCE-IDoverride, i.e. "this event only"). It asserts onechanged/timerow each, the exact old and new times for the single event, and one pending delivery per change.Test only; no production code changes.
Tests
Full backend suite: 475 passed, 6 skipped.
🤖 Generated with Claude Code