Repository navigation
feat(accounts): check the password-reset link before the new password is typed - #19
Merged
Merged
Conversation
…typed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is typed The reset page asks a new side-effect-free POST /api/auth/password-reset/check whether the link is still usable and shows the "link no longer works" panel instead of the form when it is not. The lookup is shared with the submit, so both apply the same rules; submitting still checks again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/auth/password-reset/check { token }when it opens, and shows the existing "link no longer works" panel instead of the form when the link is used, expired, replaced, unknown, missing, or the account is disabled.FindResetAsync) shared by the check and the submit, so both apply the same rules; submitting still checks again.loadskips the check, so the action's result (done / token_invalid / password error) decides the page.specs/009-reset-link-precheck/.Test plan
dotnet testfiltered toSignInTests|ApiTests|LogHygieneTests: 37 passed (new:ResetCheckRefusesDeadLinks,ResetCheckChangesNothing)npm test(143 passed, incl. newreset.test.ts) andnpm run check🤖 Generated with Claude Code