feat: wire public-visibility uploads through the external-signer flow#32
Draft
Nic-dorman wants to merge 1 commit intomainfrom
Draft
feat: wire public-visibility uploads through the external-signer flow#32Nic-dorman wants to merge 1 commit intomainfrom
Nic-dorman wants to merge 1 commit intomainfrom
Conversation
Threads a visibility flag through start_upload -> file_prepare_upload_with_visibility (ant-core PR #39), carries data_map_address out of finalize_upload and finalize_upload_merkle, persists it in upload_history.json, and re-enables the previously disabled "Public" button in the upload dialog. Public uploads now yield a single shareable on-network chunk address that appears in the uploads table with a "Public" badge; clicking copies it. The dialog re-quotes when the user toggles visibility because the payment batch differs (public adds one chunk for the DataMap itself). Requires bumping the ant-core git dep to a commit containing WithAutonomi/ant-client#39. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch does not compile against today's ant-core pin. It calls
Client::file_prepare_upload_with_visibilityand readsFileUploadResult.data_map_address, both of which land with ant-client #39 (approved by @mickvandijke, waiting to merge). The plan once #39 lands:ant-corerevinsrc-tauri/Cargo.tomlto the post-merge commitOpened as draft now so the ant-gui work is discoverable alongside the upstream PR.
Summary
Re-enables the Public visibility option in the upload dialog (currently disabled with "Coming soon") by threading a
visibilityflag through the external-signer flow. Public uploads yield a single shareable on-network chunk address (the published DataMap); clicking it in the uploads table copies it to the clipboard for sharing.Changes
Backend (`src-tauri`)
Frontend
Test plan
🤖 Generated with Claude Code