fix: handle ant-node payment_vault_address unification#22
Closed
Nic-dorman wants to merge 1 commit intomainfrom
Closed
fix: handle ant-node payment_vault_address unification#22Nic-dorman wants to merge 1 commit intomainfrom
Nic-dorman wants to merge 1 commit intomainfrom
Conversation
ant-node unified data_payments_address + merkle_payments_address into a single payment_vault_address. All three start scripts now try the new key first, falling back to old keys for backward compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
Collaborator
Author
|
Superseded by #23 which includes this fix as part of the full payment_vault_address unification across all SDKs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ant-node on main (commit
a08a727) unifieddata_payments_address+merkle_payments_addressinto a singlepayment_vault_addressin the devnet manifest. This breaks the start scripts which read those fields.scripts/start-local.sh— fallback chain:payment_vault_address→data_payments_addressscripts/start-local.ps1— same fallback logic for PowerShellant-dev/src/ant_dev/cmd_start.py— same fallback for theant startCLIAll three files remain backward compatible with older ant-node versions that still emit the separate keys.
Note
This only fixes manifest parsing in the start scripts. The antd daemon itself still uses
EVM_DATA_PAYMENTS_ADDRESSandEVM_MERKLE_PAYMENTS_ADDRESSenv vars internally — those will need a separate update whenant-coreis updated to match.Test plan
./scripts/start-local.shagainst current ant-node main — verify payments address resolvesant startvia ant-dev — verify same🤖 Generated with Claude Code