Skip to content

Extract wire protocol to ant-protocol; bump to 0.11.0 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grumbach wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Extract wire protocol to ant-protocol; bump to 0.11.0 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd07651
Depend on ant-protocol 2.0.0; bump to 0.11.0
grumbach Apr 17, 2026
3adbabb
chore: merge main, resolve conflicts (keep 0.11.0)
grumbach Apr 21, 2026
0fe0089
chore: restore version to 0.10.1 and drop CHANGELOG
jacderida Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@ name = "ant-devnet"
path = "src/bin/ant-devnet/main.rs"

[dependencies]
# Wire protocol — the single version-pin shared with ant-client.
# Bumping ant-protocol's `evmlib`/`saorsa-core`/`saorsa-pqc` pins ripples
# through here automatically; we keep a direct saorsa-core dep for
# node-only DHT internals (DHTNode, TrustEvent, DhtNetworkEvent), which
# Cargo unifies with ant-protocol's version constraint.
#
# TODO: swap to `ant-protocol = "2.0.0"` once 2.0.0 is on crates.io.
# The git ref is the tagged `main` commit at the time of this PR and
# stays byte-for-byte identical to what will be published.
Comment on lines +33 to +34
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above the ant-protocol dependency mentions using a "git ref" / "tagged main commit", but the manifest currently uses a local path dependency. Please update the comment to match the actual dependency strategy (path vs git vs crates.io) to avoid confusion during release/publish steps.

Suggested change
# The git ref is the tagged `main` commit at the time of this PR and
# stays byte-for-byte identical to what will be published.
# For now this uses a local path dependency during development/release
# coordination; keep the version in sync with what will be published.

Copilot uses AI. Check for mistakes.
# TODO: swap to `ant-protocol = "2.0.0"` once 2.0.0 is on crates.io.
# The pinned commit matches the current `WithAutonomi/ant-protocol` main.
Comment on lines +35 to +36
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO: swap to ant-protocol = "2.0.0" once 2.0.0 is on crates.io. note appears twice in a row. Could you remove the duplicate to keep the dependency block concise and avoid confusion about whether there are two separate follow-ups?

Suggested change
# TODO: swap to `ant-protocol = "2.0.0"` once 2.0.0 is on crates.io.
# The pinned commit matches the current `WithAutonomi/ant-protocol` main.

Copilot uses AI. Check for mistakes.
ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", rev = "597dbdb1b680a43d80a082d77076ff2080444079" }
Comment on lines +31 to +37
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ant-protocol is currently pulled via a git dependency. If ant-node is intended to be published to crates.io as 0.11.0, cargo publish will fail because published crates cannot depend on git (or path) dependencies. Please switch this to a crates.io version requirement (e.g. 2.0.0) before merge/release, and if you still need the pinned revision for development, consider using a temporary [patch.crates-io] override in a non-published workspace context instead.

Suggested change
#
# TODO: swap to `ant-protocol = "2.0.0"` once 2.0.0 is on crates.io.
# The git ref is the tagged `main` commit at the time of this PR and
# stays byte-for-byte identical to what will be published.
# TODO: swap to `ant-protocol = "2.0.0"` once 2.0.0 is on crates.io.
# The pinned commit matches the current `WithAutonomi/ant-protocol` main.
ant-protocol = { git = "https://github.com/WithAutonomi/ant-protocol", rev = "597dbdb1b680a43d80a082d77076ff2080444079" }
ant-protocol = "2.0.0"

Copilot uses AI. Check for mistakes.
Comment on lines +32 to +37
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ant-node cannot be published to crates.io with a git dependency, and the PR description says the ant-protocol 2.0.0 publish should happen before merge. This should be switched to a crates.io version pin (e.g. ant-protocol = "2.0.0") before merging/releasing, and the duplicate TODO line should be removed.

Copilot uses AI. Check for mistakes.

# Core (provides EVERYTHING: networking, DHT, security, trust, storage)
saorsa-core = "0.23.1"
saorsa-pqc = "0.5"
Expand Down
Loading
Loading