Skip to content

fix: skip Windows Hello entirely when protection is Off - #365

Open
Wibias wants to merge 12 commits into
mainfrom
fix/off-mode-never-hello
Open

fix: skip Windows Hello entirely when protection is Off#365
Wibias wants to merge 12 commits into
mainfrom
fix/off-mode-never-hello

Conversation

@Wibias

@Wibias Wibias commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Protection Mode Off no longer prompts Windows Hello for independent-intent lifecycle writes such as update_pr_body, create_pr, and merge_pr.
  • Sensitive actions (high-assurance) still requires Hello for those writes. Mutation-policy rules (explicit instruction, exact-text confirmation, expected-head checks) still apply under Off.
  • Docs and unit tests now match the Off label: Off is the Hello opt-out, not a partial skip.

Test plan

  • node --test tests/unit/authority-mode-enforcement.test.mjs tests/unit/mutation-modes-docs.test.mjs
  • node scripts/pre-open-gate.mjs Wibias/github-delivery origin/main HEAD --evidence-file .tmp/off-hello-preopen-evidence.json — ready at 0cda50b0557e0e122fda21f29405c8dd317907d0

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ff6e934-2fa1-4adb-b7d1-c76d80004af0


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias force-pushed the fix/off-mode-never-hello branch from 0cda50b to 79bb203 Compare August 24, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant