fix: skip Windows Hello entirely when protection is Off - #365
Open
Wibias wants to merge 12 commits into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wibias
force-pushed
the
fix/off-mode-never-hello
branch
from
August 24, 2026 08:21
0cda50b to
79bb203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_pr_body,create_pr, andmerge_pr.high-assurance) still requires Hello for those writes. Mutation-policy rules (explicit instruction, exact-text confirmation, expected-head checks) still apply under Off.Test plan
node --test tests/unit/authority-mode-enforcement.test.mjs tests/unit/mutation-modes-docs.test.mjsnode scripts/pre-open-gate.mjs Wibias/github-delivery origin/main HEAD --evidence-file .tmp/off-hello-preopen-evidence.json— ready at0cda50b0557e0e122fda21f29405c8dd317907d0