ci(security): scan full history on push for TruffleHog#84
Merged
Conversation
github.event.before equals HEAD on branch creation and no-op pushes, which makes the TruffleHog action fail with 'BASE and HEAD commits are the same'. Diff against the default branch only on pull_request; on push scan the full git history from HEAD instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TruffleHog secret-scan step fails with:
github.event.beforeequals HEAD on branch creation and no-op pushes, so thebase..HEADdiff is empty and the action errors out.Fix
pull_request: diff against the default branch (unchanged behavior).push: leavebaseempty so TruffleHog scans the full git history fromHEAD (
fetch-depth: 0already provides it). No more emptybase..HEADdiff.🤖 Generated with Claude Code