Skip to content

feat: incorporate population data from wikidata#2385

Merged
nijel merged 1 commit intomainfrom
population
Apr 13, 2026
Merged

feat: incorporate population data from wikidata#2385
nijel merged 1 commit intomainfrom
population

Conversation

@nijel
Copy link
Copy Markdown
Member

@nijel nijel commented Apr 13, 2026

This fills in the gaps that CLDR has.

This fills in the gaps that CLDR has.
@nijel nijel self-assigned this Apr 13, 2026
@nijel nijel enabled auto-merge (rebase) April 13, 2026 11:05
@nijel nijel merged commit e05cf6d into main Apr 13, 2026
20 checks passed
@nijel nijel deleted the population branch April 13, 2026 11:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d902cbfdaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +49 to +51
populations = dict(reader)

return [code for code in languages if int(populations.get(code, "0")) == 0]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Build fallback candidate list from CLDR-only populations

load_zero_population_codes() derives its worklist from the current population.csv, but this commit now populates population.csv with values from population-fallback.csv; as a result, rerunning this helper excludes previously backfilled languages and can produce a truncated fallback file that drops existing rows. If that output is committed and population.csv is regenerated, many languages revert to zero again, so the refresh workflow is not idempotent. The candidate set should come from unsupplemented CLDR output (or otherwise ignore existing fallback contributions) before querying Wikidata.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant