Skip to content

Simplify updateUIAfterRun#99

Merged
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-07-29_id_cleanup
Jul 29, 2025
Merged

Simplify updateUIAfterRun#99
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-07-29_id_cleanup

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

@camillobruni camillobruni commented Jul 29, 2025

  • Rewrite score getter to use dubScore values directly
  • Add allScores() helper that also returns the Score value
  • Rewrite scoreIdentifiers to use allScores()
  • Implement single updateUIAfterRun() and use allScores()

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 29, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit f3e4848
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/6888fee69e7eec00081a80f1
😎 Deploy Preview https://deploy-preview-99--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from danleh July 29, 2025 13:33
@camillobruni camillobruni changed the title Simplify updateUiAfterRun Simplify updateUIAfterRun Jul 29, 2025
Copy link
Copy Markdown
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. Thanks again!

Comment thread JetStreamDriver.js Outdated
Comment thread JetStreamDriver.js Outdated
Comment thread JetStreamDriver.js Outdated
Comment thread JetStreamDriver.js
Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this broke the cli printing:

% ~/.jsvu/bin/v8 cli.js
Starting JetStream3
Running zlib-wasm:
Running WSL:
Running UniPoker:
Running uglify-js-wtb:

I get the same output for all the shells.

@camillobruni
Copy link
Copy Markdown
Contributor Author

  • Fixed the shell printing.
  • Now I also always console.print when running in the browser

Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now too.

@camillobruni camillobruni merged commit e1acad0 into WebKit:main Jul 29, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-07-29_id_cleanup branch July 29, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants