Skip to content

Add info-button#123

Merged
camillobruni merged 13 commits into
WebKit:mainfrom
camillobruni:2025-08-11_info_button
Aug 12, 2025
Merged

Add info-button#123
camillobruni merged 13 commits into
WebKit:mainfrom
camillobruni:2025-08-11_info_button

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

@camillobruni camillobruni commented Aug 11, 2025

It's very easy to end up on the in-depth.html info page when clicking on a benchmark name. This is rather annoying if you're on a result page and loose all information.

  • Add a "i" info link
  • Update the in-depth.html to highlight the current selected workload (it's too easy to miss)
Screenshot 2025-08-11 at 16 59 05

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 11, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit f89bcf7
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/689a06a2bb0bb3000918ecb4
😎 Deploy Preview https://deploy-preview-123--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from danleh August 12, 2025 09:48
Copy link
Copy Markdown
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with optional tiny nit: can we move the circle a bit up by using vertical-align: text-top; instead of middle?

@camillobruni
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-08-12 at 14 35 16

@camillobruni camillobruni merged commit 40fbbac into WebKit:main Aug 12, 2025
14 of 16 checks passed
@camillobruni camillobruni deleted the 2025-08-11_info_button branch August 12, 2025 14:08
@camillobruni camillobruni restored the 2025-08-11_info_button branch August 12, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants