Proposal: Use ScoreGroup for SunSpider#122
Closed
camillobruni wants to merge 2 commits into
Closed
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@iainireland this would be an alternative approach to handle SunSpider, which would not require changing the underlying workloads. |
camillobruni
changed the title
Contributor
|
I wonder if it's cleaner to have a new Benchmark subclass that does the grouping? Let me see if I can whip that up for comparison. |
Contributor
Author
|
Yes, I definitely would prefer that... but didn't feel like hacking too much :). Definitely fine with going with your approach here! |
Contributor
|
Should we close this now that we went with the GroupedBenchmark strategy? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running SunSpider in the same realm is error prone, it modifies global state and thus it requires additional changes to get it working.
Instead of #113 where we run all SunSpider workloads in a single run, I propose using a ScoreGroup which produces a single geomean score for all the SunSpider line items. This would also be easily applicable to Octane.
Discussion points: