feat!: include null/false getter values and add #[JsonIgnore] attribute#66
Merged
Merged
Conversation
added 3 commits
June 9, 2026 00:35
- Remove the null/false filter in JsonConverter::objectToJson() so all getter return values are serialized (null becomes JSON null, false becomes JSON false). - Add #[JsonIgnore] attribute (TARGET_METHOD | TARGET_PROPERTY) for explicit exclusion of getters and public properties. - Add tests for both behaviors. Closes #57
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include all getter return values (including
nullandfalse) in serialized output and add#[JsonIgnore]attribute for explicit exclusion.Motivation
Getters returning
nullorfalsewere silently dropped, causing boolean data loss and inconsistency with public property handling. Fixes #57.Changes
null/falsefilter inJsonConverter::objectToJson()— all getter values are now serialized#[JsonIgnore]attribute (TARGET_METHOD | TARGET_PROPERTY) for opt-out exclusionObjWithNullFalseGettersandObjWithIgnoredPropstest helpers#[JsonIgnore]on both getters and propertiesHow to Test / Verify
Unit tests:
testGetterReturningNullIsIncluded,testGetterReturningFalseIsIncluded,testJsonIgnoreOnGetter,testJsonIgnoreOnPublicProperty.Breaking Changes and Migration Steps
Breaking: objects that previously relied on returning
nullorfalsefrom getters to hide properties will now have those properties appear in output. Developers should add#[JsonIgnore]to explicitly exclude properties.Checklist
composer fix-cs)Related issues
Closes #57