fix: serialize stdClass dynamic properties in Json::add()#65
Merged
Conversation
added 2 commits
June 8, 2026 23:51
stdClass objects have dynamic properties that are not visible to ReflectionClass::getProperties(). Add an early return that converts them using get_object_vars() so their properties are serialized. Closes #54
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Json::add()to correctly serializestdClassobjects by reading their dynamic properties viaget_object_vars().Motivation
Users returning
stdClassobjects (e.g. via(object)[...]cast) get empty{}in JSON output. Fixes #54.Changes
How to Test / Verify
Unit tests:
testStdClassSerializationandtestStdClassInArrayinJsonTest.php. Currently failing, confirming the bug.Breaking Changes and Migration Steps
None
Checklist
composer fix-cs)Related issues
Closes #54