You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is similar to #1798, but I think that got ignored because WayofTime was busy.
en_us.json is made using a Data Generator. In order for the language file change to stay around, the changes also have to be made in src/main/java/wayoftime/bloodmagic/common/data/GeneratorLanguage.java.
Notes for potential translators:
The "patchouli.bloodmagic.(etc)" translation keys are planned to be moved to "guide.patchouli.bloodmagic.(etc)" keys in the near future. Any portion of an Entry generated via code should work with translations set there.
Not using the language files for the actual Patchouli Entries (book.json's i18n option, default false) is an intentional decision. It would make working with the book far more tedious (reload all resources every time you change an entry vs. just reloading the book), and changing language will almost certainly lengthen or contract text to the point where page formatting would have to change. Patchouli's default method of translations is to have translated versions of the book in their own folders (same level as the en_us folder). The en_us version is the master, and translations can replace those entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the pachoulii load method, the guide book cannot be translated unless you use the i18n key. So I patch it.