Skip to content

fix: validate_rows now raises a ValidationError for non-list inputs#327

Open
Esun4 wants to merge 1 commit intoWat-Street:mainfrom
Esun4:validate_rows_check
Open

fix: validate_rows now raises a ValidationError for non-list inputs#327
Esun4 wants to merge 1 commit intoWat-Street:mainfrom
Esun4:validate_rows_check

Conversation

@Esun4
Copy link
Copy Markdown

@Esun4 Esun4 commented May 2, 2026

I identified what the actual problem was, which was that the validate_rows function assumes that the data_list type is always a list, but never checked so when it wasn't the function wouldn't raise a ValidationError. The fix that I implemented was just adding a type check at the top of the function. If the type of data_list isn't a list the function now raises a validation error, if it is a list then it will continue like normal. I chose to use type() over isinstance, because the types we are checking for (None and dict) are not subclasses of list, so both will have the same behaviour and type() is a little clearer on the intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant