fix: validate_rows now raises a ValidationError for non-list inputs#327
Open
Esun4 wants to merge 1 commit intoWat-Street:mainfrom
Open
fix: validate_rows now raises a ValidationError for non-list inputs#327Esun4 wants to merge 1 commit intoWat-Street:mainfrom
Esun4 wants to merge 1 commit intoWat-Street:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I identified what the actual problem was, which was that the validate_rows function assumes that the data_list type is always a list, but never checked so when it wasn't the function wouldn't raise a ValidationError. The fix that I implemented was just adding a type check at the top of the function. If the type of data_list isn't a list the function now raises a validation error, if it is a list then it will continue like normal. I chose to use type() over isinstance, because the types we are checking for (None and dict) are not subclasses of list, so both will have the same behaviour and type() is a little clearer on the intent.