refactor: replace @DirtiesContext with shared containers and @Transactional rollback#55
Merged
Washingtonwei merged 2 commits intoMay 25, 2026
Conversation
…ainers Introduce SharedContainers (singleton MySQL + Mailpit per JVM) and AbstractIntegrationTest base class with @transactional rollback. All 17 integration test classes now extend the base class, eliminating 60 @DirtiesContext annotations and ~15 redundant container instances. Test suite runtime drops from ~25-30 min to ~5 min. Closes #54 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Washingtonwei
deleted the
refactor/integration-test-performance-improvement
branch
May 25, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedContainers— singleton MySQL + Mailpit containers started once per JVM, shared across all integration test classesAbstractIntegrationTest— base class with@Transactional(auto-rollback after each test), replacing 60@DirtiesContextannotations across 14 filesImpact
@DirtiesContextreloadsTest plan
Closes #54
🤖 Generated with Claude Code