Checking if logic is correct for banks - #49
Open
sohnshaik wants to merge 3 commits into
Open
Conversation
banks made comments on how we needed to fix, made fix and waiting for review.
stevehagino
reviewed
Aug 29, 2025
| .until(trg_teleopScoreReq) | ||
| .andThen(drivetrain.applyRequest(getTeleSwerveReq())); | ||
| } | ||
| if(slow) { |
There was a problem hiding this comment.
If you reassign driverXVelo/driverYVelo in this if statement, you don't need to duplicate the return statement
TESTED: everything works as intended, just need to implement a slew rate limiter that way robot wont tip when going to L3/4 fast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please review bank por favor