fix: correct error handling in connect method

[2wheeh]

Breaking Changes

N/A

Changes

• fix: correct error handling in connect method

Associated Issues

closes #40

Description

1. Currently, the reject call in the subscription callback is handled by useConnect's catch block, bypassing WalletConnectModalSign.connect's error handling
2. This causes the approval promise chain to remain pending after Modal closed error
3. When a subsequent connection attempt succeeds, the lingering approval promise from the previous attempt consumes this success
4. This leaves the second attempt's promise unresolved, keeping subscribing modal
5. When the previous resolved promise reaches finally, it closes the modal, and the subscription from the subsequent attempt throws a Modal closed error

To fix this, I consolidated the approval promise and modal closure handling within the connect method using Promise.race, ensuring that either a successful connection or modal closure properly resolves/rejects the promise chain.

After

2024-12-03.11.38.30.mov

[2wheeh]

@Cali93 @ganchoradkov Hi could I ask you to review this?

[2wheeh]

@Cali93 @ganchoradkov kind reminder here 👀

[2wheeh]

@Cali93 @ganchoradkov Hi! Another very kine reminder to review this.