P0072 | Orginazation details script #430
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| // .mat-form-field-disabled.timezone-field, | ||
| // .mat-form-field .mdc-text-field--disabled { | ||
| // opacity: 0.7; | ||
|
|
||
| // .mat-select-value, | ||
| // .mat-select-value-text, | ||
| // .mat-input-element, | ||
| // mat-label, | ||
| // .mat-form-field-label { | ||
| // color: rgba(0, 0, 0, 0.38) !important; | ||
| // } | ||
| // .mat-select-arrow, | ||
| // .mat-select-arrow svg { | ||
| // color: rgba(0, 0, 0, 0.38) !important; | ||
| // fill: rgba(0, 0, 0, 0.38) !important; | ||
| // } | ||
| // .mdc-notched-outline__leading, | ||
| // .mdc-notched-outline__notch, | ||
| // .mdc-notched-outline__trailing, | ||
| // .mat-form-field-outline { | ||
| // border-color: rgba(0, 0, 0, 0.12) !important; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
The disabled form field styles are being commented out in both light and dark themes. If these styles aren't being replaced elsewhere, this could cause accessibility issues as users may not be able to visually distinguish between enabled and disabled form fields. Consider either keeping these styles or providing alternative styling for disabled fields.
|
|
||
| ngOnInit(): void { | ||
| this.organizationForm.get('timeZoneName')?.disable(); | ||
| // this.organizationForm.get('timeZoneName')?.disable(); |
There was a problem hiding this comment.
Uncommenting this line makes the 'timeZoneName' field directly editable by users, which could lead to inconsistencies with the 'timezone' field. The component has logic that updates 'timezone' based on 'timeZoneName' changes, but not vice versa. If users can directly edit 'timeZoneName', they might enter values that don't correspond to any valid timezone offset.
Consider either:
- Keeping the field disabled as it was before
- Adding validation to ensure 'timeZoneName' always corresponds to a valid timezone
- Implementing two-way synchronization between 'timezone' and 'timeZoneName'
2 participants
No description provided.