P0072 | Orginazation details script #428
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (2)
- apps/proxy-auth/src/app/otp/organization-details/organization-details.component.scss (233-255) There's significant duplication between the disabled form field styles in light theme (lines 233-255) and dark theme (lines 387-409). Consider using a shared mixin or CSS variables to reduce duplication and make future maintenance easier.
- apps/proxy-auth/src/app/otp/organization-details/organization-details.component.ts (138-138) Good change from `this.organizationForm.value` to `this.organizationForm.getRawValue()` since it properly includes the disabled timeZoneName field. Consider adding a brief comment explaining why getRawValue() is necessary here to help future developers understand the reasoning.
💡 To request another review, post a new comment with "/windsurf-review".
| // this.snackBar.open(res?.data?.message ?? 'Information successfully updated', '✕', { | ||
| // duration: 3000, | ||
| // horizontalPosition: 'center', | ||
| // verticalPosition: 'top', | ||
| // panelClass: ['success-snackbar'], | ||
| // }); |
There was a problem hiding this comment.
The snackbar notifications have been commented out for both success and error cases. Without these notifications, users won't receive any feedback when their organization details are updated or when an error occurs. Was this intentional? If so, is there an alternative feedback mechanism being implemented?
| .mat-select-value, | ||
| .mat-select-value-text, | ||
| .mat-select-value-text span, | ||
| .mat-input-element, |
There was a problem hiding this comment.
The dark theme disabled styles include .mat-select-value-text span on line 394 that's missing from the equivalent light theme section. This could cause inconsistent styling between themes.
| .mdc-notched-outline__notch, | ||
| .mdc-notched-outline__trailing, | ||
| .mat-form-field-outline { | ||
| border-color: rgba(0, 0, 0, 0.12) !important; |
There was a problem hiding this comment.
The light theme includes .mat-form-field-outline on line 253 in the disabled styles, but this selector is missing from the dark theme version. This could cause inconsistent styling between themes.
2 participants
No description provided.