fix(actions): default outcome to Private Note for hidden actions, surface Halo validation errors - #96
Open
wyre-agent-fleet[bot] wants to merge 3 commits into
Open
wyre-agent-fleet[bot] wants to merge 3 commits into
wyre-agent-fleet[bot] wants to merge 3 commits into
Conversation
…face Halo validation errors Halo's API rejects a posted action with no outcome field, even when hidden_from_user is set -- it read as intermittent because it only bit when the caller omitted outcome. Defaults outcome to "Private Note" for hidden actions when not supplied, and surfaces HaloPsaValidationError's field-level detail instead of the generic error message so a future rejection like this names the missing field directly.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
# Conflicts: # CHANGELOG.md # src/mcp-server.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outcomefield, even whenhidden_from_useris set. It read as intermittent because it only bit when the caller omittedoutcome— action ci: adopt codeql-action v4 (node24) via reusable-workflow pin bump #64 succeeded onceoutcomewas supplied.halopsa_tickets_add_actionnow defaultsoutcometo"Private Note"whenhidden_from_useris true and the caller didn't supply one. Visible (non-hidden) actions are left unchanged — no evidence yet on whether they need a different default, so this only fixes the reported case.mcp-server.tsonly surfacederror.message, which is just"Validation error"for aHaloPsaValidationError— the actual field-level detail (error.errors) was silently discarded. Now surfaced, so any future Halo validation rejection names the specific field instead of a generic message.Test plan
npm run typecheck— cleannpx vitest run— 149/149 passing (2 new tests covering the default-outcome and no-default-for-visible-actions cases)npm run lint— cleanNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.