forked from asachs01/cortextos
-
Notifications
You must be signed in to change notification settings - Fork 0
docs(autoresearch): skip-not-orphan when a fixed cron fires before the experiment window closes #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asachs01
wants to merge
1
commit into
main
Choose a base branch
from
fix/autoresearch-window-skip-not-orphan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs(autoresearch): skip-not-orphan when a fixed cron fires before the experiment window closes #173
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Block all experiment actions while the active measurement window is open.
The new branch defers evaluation but can still fall through to later experiment creation or execution. Because
runExperimentwrites the singletonexperiments/active.jsonrecord, another experiment can replace the still-running experiment before its window closes.templates/agent-codex/plugins/cortextos-agent-skills/skills/autoresearch/SKILL.md#L37-L37: state that only unrelated cron work may continue.templates/agent-opencode/plugins/cortextos-agent-skills/skills/autoresearch/SKILL.md#L37-L37: prevent Step 3, Step 4, and orphan-proposal execution during this fire.templates/agent/.claude/skills/autoresearch/SKILL.md#L38-L38: prevent creation or execution of another experiment.templates/analyst/.claude/skills/autoresearch/SKILL.md#L38-L38: preserve the currentexperiments/active.jsonrecord until evaluation.templates/orchestrator/.claude/skills/autoresearch/SKILL.md#L38-L38: apply the same lifecycle guard as the other templates.🧰 Tools
🪛 SkillSpector (2.9.5)
[warning] 19: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation.
Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state.
(Excessive Agency (EA2))
[warning] 181: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation.
Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state.
(Excessive Agency (EA2))
📍 Affects 5 files
templates/agent-codex/plugins/cortextos-agent-skills/skills/autoresearch/SKILL.md#L37-L37(this comment)templates/agent-opencode/plugins/cortextos-agent-skills/skills/autoresearch/SKILL.md#L37-L37templates/agent/.claude/skills/autoresearch/SKILL.md#L38-L38templates/analyst/.claude/skills/autoresearch/SKILL.md#L38-L38templates/orchestrator/.claude/skills/autoresearch/SKILL.md#L38-L38🤖 Prompt for AI Agents