feat(bus): add --blocked-by to update-task for post-creation blockers - #141
Open
asachs01 wants to merge 1 commit into
Open
feat(bus): add --blocked-by to update-task for post-creation blockers#141asachs01 wants to merge 1 commit into
asachs01 wants to merge 1 commit into
Conversation
asachs01
force-pushed
the
feat/update-task-blocked-by
branch
4 times, most recently
from
August 22, 2026 06:29
94cb751 to
27a5328
Compare
blocked_by was only settable at create-task time; a task that transitions to blocked AFTER creation (the normal case) had no structured way to record what blocks it, beyond an unstructured event-meta note the tooling can't read. check-stale-blockers was scanning 100+ blocked tasks a night and finding almost none of them checkable for exactly this reason. Additive (never replaces the existing list), deduped, cycle-checked the same way create-task is (rejecting before any write), and writes the same symmetric blocks edge on the peer that create-task does. Closes task_1786923653812_76952898, task_1786773702893_68177835.
asachs01
force-pushed
the
feat/update-task-blocked-by
branch
from
August 22, 2026 06:35
27a5328 to
f1a88a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task_1786923653812_76952898/task_1786773702893_68177835(two independent filings of the same gap, grower + boss):update-taskonly accepted--assignee/--project— there was no way to attach ablocked_byedge to a task after creation, even though a task normally transitions toblockedstatus after it already exists (that's what triggers the transition in the first place). The only workaround was an unstructuredlog-event ... --meta blocked_by:...note that no tooling reads.check-stale-blockersscanning 100+ blocked tasks a night and finding almost none of them checkable, because they carry noblocked_byfield at all — this is also what motivated fix(bus): add coverage denominator to checkStaleBlockers summary #140 (coverage denominator), merged/pending ahead of this one per the filing's own ordering argument.--blocked-by <ids>toupdate-task(comma-separated), and a matchingblockedBy?: string[]option onupdateTask(). Semantics: additive (appends to the existing list, never replaces it — dedupes ids already present), cycle-checked the same waycreate-taskis (rejects before any write, so a rejected cycle leaves zero partial state), and writes the same symmetricblocksedge on the peer task thatcreate-taskdoes.Test plan
npx vitest run tests/unit/bus/task.test.ts— 71/71 passing, including 8 new tests: basic add, additive-not-replace, dedup, cycle rejection (both a general loop and self-reference), the zero-partial-state regression shape (mirroring the existingcreateTaskcycle regression test), audit log entry, and the exact motivating scenario end-to-end (blocked task with noblocked_by→ attach after the fact →checkTaskDependenciescan now evaluate it)task.test.ts,bus-task-error-handling-cli.test.ts)npx tsc --noEmit— cleanphase5-performance.test.ts/cron-scheduler.test.ts(timing/timeout under load), matching this repo's documented flaky-under-load pattern; none touchsrc/bus/task.tsorsrc/cli/bus.tsNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.