Conversation
…ntent - Explicitly declare io.modelcontextprotocol/ui in the server capabilities object (SEP-1724 extensions mechanism). - action1_get_endpoint (the only card-attached tool) now returns a short human-readable text summary in `content` and moves the full endpoint record (including _card) into `structuredContent`, per SEP-1865's content/structuredContent separation. No fields dropped, only relocated. - Widened DomainHandler.handle's return type to allow optional structuredContent. - Updated mcp-apps.test.ts and domains/endpoints.test.ts assertions. Part of a fleet-wide mechanical SEP-1865 compliance backport.
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Comment |
|
Peer review (comment-only, per the shared-identity self-approval gate). Verdict: approve, no blockers. Part of the 14-PR SEP-1865 fleet batch triage. Reviewed against the already-approved reference pattern in this batch (itglue-mcp#107):
No unrelated changes, scope is clean. |
Summary
Two small mechanical SEP-1865 spec-compliance fixes, part of a fleet-wide backport (companion PRs in
itglue-mcp,qbo-mcp,liongard-mcp). No refactors, no dependency bumps, no changes to card-building logic (card.builder.ts'sbuildDeviceCardis untouched).1. Explicit extension capability declaration
Before (
src/index.ts):After:
Shape confirmed against the spec's server-capabilities example (
SEP-2133/SEP-1865).2. content/structuredContent separation
action1_get_endpoint(the only card-attached tool) returned the whole endpoint record — including the_cardobject — as a single stringifiedcontenttext block.Before (
src/domains/endpoints.ts):After:
payloadis the exact same object previously JSON.stringified — every field is unchanged, just carried instructuredContent. Also widenedDomainHandler.handle's return type (src/utils/types.ts) to allow an optionalstructuredContentfield.Test output (real, from this branch)
Updated
src/__tests__/mcp-apps.test.tsandsrc/__tests__/domains/endpoints.test.tsto assert againstresult.structuredContentinstead of parsingcontent[0].textas JSON.Build output (real, from this branch)
No pre-existing failures encountered.
Scope
src/index.ts: capability declarationsrc/domains/endpoints.ts: action1_get_endpoint content/structuredContent splitsrc/utils/types.ts:DomainHandler.handlereturn type gains optionalstructuredContentsrc/__tests__/mcp-apps.test.ts,src/__tests__/domains/endpoints.test.ts: updated assertionsNot merging — for review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.