fix(ci): retarget release GHCR image to our own org namespace - #5
Merged
Conversation
release.yml's docker/metadata-action was still hardcoded to ghcr.io/corebunch/instatic (upstream's own package), unmodified since this repo was forked. A real tag-triggered release would have tried to publish into a namespace we don't own instead of landing anywhere we control. Computed the image path from github.repository, lowercased, using the same fix already shipped in WYRE-AI/conduit's deploy.yml after that repo's own org move broke an equivalent hardcoded/case-sensitive ref.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml's image publish step was still hardcoded toghcr.io/corebunch/instatic(upstream's own package name), unmodified since this repo was forked -- a realv*.*.*tag push would have tried to publish into a namespace we don't own instead of landing anywhere we control.github.repository, lowercased, following the same fix already shipped inWYRE-AI/conduit'sdeploy.ymlafter that repo's own org move broke an equivalent case-sensitive/hardcoded ref.Test plan
python3 -c "import yaml; yaml.safe_load(...)")v*.*.*tags, not on PRs) -- next real version tag will be the first live exercise of the fixed path.Context: part of the instatic-plugins investigation (task_1788833699913_71019278), authorized by boss for this fork/CI without needing Aaron.
Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.