Fix for Basic Auth not being passed through with PHP in CGI mode#32
Fix for Basic Auth not being passed through with PHP in CGI mode#32graham73may wants to merge 7 commits intoWP-API:masterfrom
Conversation
|
FYI pulled into https://github.com/eventespresso/Basic-Auth |
|
This is sorely needed, this was hard to track. Please consider merging. |
|
Just flagged this in core slack to see if @rmccue et al can take a look |
|
Any progress on this issue? For the moment I am using @mnelson4 version https://github.com/eventespresso/Basic-Auth which works A+ |
|
The solution developed here https://github.com/eventespresso/Basic-Auth is the best one in my opinion because it does not suggest any Apache-specific solutions. The handling of HTTP headers is best handled in PHP, then the plugin just works with any web server. Thanks @mnelson4! |
|
@rmccue Could you review this? |
|
Thanks so much, this fixed my issue with Basic Authentication not working 👍 |
Tug
left a comment
There was a problem hiding this comment.
I know this is quite an old one but I did a similar patch and just found out about this PR :)
This should be quite useful for sites who use CGI/FastCGI imo!
|
This was approved a year ago. A number of hosts use FastCGI and telling customers to use an htaccess workaround to force HTTP for auth is not really a good security practice. Can this please be revisited for WP 5.5? |
|
I know this is an incredibly old PR at this point but I've resolved the review comments in the hope that this might be merged one day. |
#1 Issue fixed.
PHP_AUTH_USER & PHP_AUTH_PW are now being set if PHP is using fast CGI