feat(Registration): Email verification - #2328
Conversation
❌ 1 blocking issue (1 total)
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
breity
left a comment
There was a problem hiding this comment.
Functionality works well. I split some of the verification messages into separate elements to simplify the i18n messages. I also cleaned up the login-home template a little.
One issue: If user clicks the link to re-send the verification email, the countdown to send another verification email starts properly. But if the user refreshes or reloads the login page and then tries to sign again, the link to send another email shows up and the countdown is reset because the component has been reloaded. Kind of an edge case, so not sure if it's worth addressing, as it would add complexity to the code. @Aaron-Detre @hirokiterashima, what do you think?

Changes
Test