Skip to content

Add fully active check in start() #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaseley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fully active check in start() #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ The <dfn method for=IdleDetector>requestPermission()</dfn> method steps are:

The <dfn method for=IdleDetector>start(|options|)</dfn> method steps are:

1. If the [=relevant global object=] of [=this=] is a {{Window}} object whose
[=associated Document=] is not [=fully active=], return [=a promise rejected with=]
Comment on lines +284 to +285

@reillyeon reillyeon Sep 28, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equivalent worker concept is "active needed worker". You're right that the code below assumes a Document because the Permissions Policy spec does not currently define how it works in workers. In Chromium, since this API is only available in dedicated workers, the permissions policy is simply inherited from the owning document.

an "{{InvalidStateError}}" {{DOMException}}.
<wpt>
idle-detection-detached-frame.https.html
</wpt>
1. If the [=relevant global object=]'s [=associated Document=] is not [=allowed
to use=] <a permission>"idle-detection"</a>, return [=a promise rejected with=] a
"{{NotAllowedError}}" {{DOMException}}.
Expand Down