Remove copy and move methods.#50
Merged
Merged
Conversation
These methods don't provide much value, since it is possible to get the same behavior using the existing read and write APIs.
pwnall
approved these changes
May 14, 2019
pwnall
left a comment
pwnall
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thank you for the simplification!
|
So simply renaming a file requires you to read the hole file and write it to the new destination (essentially copying the hole file) and then deleting the original file 😞 kind of wasteful operation and not so fast performant... |
|
Say you want to rename a 4gb movie and only have 2 gb free space... problematic. |
Collaborator
This was referenced Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods don't provide much value, since it is possible to get the
same behavior using the existing read and write APIs.
This fixes #52 and #53