Skip to content

Report metadata #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
interob merged 3 commits into from
Oct 7, 2025
Merged

Report metadata #193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc33830
writes metadata to stdout for diagnostics
Oct 6, 2025
b7f20cb
tries to locate the problem
Oct 6, 2025
d10345d
accepts file if metadata cannot be parsed
Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions modape/modis/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,17 +234,24 @@ def _check(_downloaded: Path, raise_on_error=True) -> bool:
allow_redirects=True,
) as cmrxml:
cmrxml.raise_for_status()
file_metadata = self._parse_cmrxml(
cmrxml, url.split("/")[-1]
)
try:
file_metadata = self._parse_cmrxml(
cmrxml, url.split("/")[-1]
)
except AttributeError:
log.info(
f"WARNING: Metadata cannot be parsed for {url.split('/')[-1]}!"
)
return True
else:
hdfxml.raise_for_status()
file_metadata = self._parse_hdfxml(hdfxml)

# check filesize
# check filesize:
assert (
str(_downloaded.stat().st_size).strip() == file_metadata["FileSize"]
), f"Size: {_downloaded.stat().st_size} != {file_metadata['FileSize']}"
# check hash (checksum):
with open(_downloaded, "rb") as openfile:
if file_metadata["ChecksumType"] == "CKSUM":
checksum = str(cksum(openfile))
Expand All @@ -266,7 +273,6 @@ def _check(_downloaded: Path, raise_on_error=True) -> bool:
raise ValueError(
f"Unknown Checksum Type: {file_metadata['ChecksumType']}"
)
# check checksum
assert checksum == file_metadata["Checksum"], (
f"Hash: {checksum} != {file_metadata['Checksum']}"
)
Expand Down