Open
Conversation
added 2 commits
February 17, 2022 08:29
Contributor
|
Master it currently doesn't support korean so you probably missed it when searching around, but for it to work with russian you should need to make changes here and a few spots around here. If you're unfamiliar with the feature, you can find instructions for how to use Master It in #183 |
Corentin-Aulagnet
added a commit
to Corentin-Aulagnet/WFinfo
that referenced
this pull request
Jun 30, 2022
… on warframe market. It is similar to WFCD#231 MasterIt has not been tested. Displays are not translated.
|
@BLG51 hear us out. You almost did this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you fix? (provide a description or issue closes statement)
Added russian lang recognition, also slightly altered method that was finding eng -> other language translation to compare names correctly
Evidence/screenshot/link to line
I posted a screenshot on discord
Considerations
I specified that minimum number of characters in the name of the item is 16, but I'm not so sure about that. Didn't find anything shorter tho.
Also eng -> other language method was working weird and wasn't showing all names which broke some items recognition so I changed it a little, but korean version also uses it. I don't think It broke something on their end since It's not locale specific.