Skip to content

address-review: a mitigation is Disputed, not Fixed; a new user-facing rule is the maintainer's - #125

Merged
allenhutchison merged 1 commit into
mainfrom
claude/project-thread-olhd3i
Nov 8, 2026
Merged

allenhutchison merged 1 commit into
mainfrom
claude/project-thread-olhd3i

Conversation

@allenhutchison

Copy link
Copy Markdown
Collaborator

Requested by Allen · project thread

Human overview

Two address-review rules from the pepper#6116 analysis. A partial change plus a deferral is answered Disputed: / Deferred:, never Fixed in, so the reviewer does not judge it fix-incomplete and argue it again. A new user-facing rule (refusal, limit, uniqueness check) added only to clear a finding counts as a behaviour choice for the maintainer, so the agent proposes it instead of shipping it.

Human required (optional)

  • Approve the approach (the option on the project thread card) before merging.

AI reviewer

  • plugins/repo-ops/skills/address-review/SKILL.md, "What blocks, and what you choose": the behaviour-choice bullet now names a new user-facing rule added to clear a finding as a case of it. A new "A mitigation is not a fix" bullet sets the reply for a partial change plus a deferral.
  • Case: on pepper#6116, the agent answered P1 VR-d20cf712 with "Fixed in 725e036, in proportion to the risk". The commit only reworded copy and deferred the real fix to groups#340. VR held it fix-incomplete, and the agent then added a display-name uniqueness refusal on its own (1e3c8ab).
  • The example in the skill text is kept generic so no Vycari repo is named in the mechanism.
  • Prose only, so no tests. Version bump is left to the bump workflow.


Generated by Claude Code

…g rule is the maintainer's

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QNDehArd5nnuPnycpyjw4R
@allenhutchison allenhutchison added the greptile:skip Skip Greptile automatic review for this PR only label Nov 8, 2026
@allenhutchison allenhutchison self-assigned this Nov 8, 2026
@allenhutchison
allenhutchison marked this pull request as ready for review November 8, 2026 20:02
@allenhutchison
allenhutchison merged commit 5906de4 into main Nov 8, 2026
1 check passed
@allenhutchison
allenhutchison deleted the claude/project-thread-olhd3i branch November 8, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greptile:skip Skip Greptile automatic review for this PR only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants